Add in dynamic version for telemetry using GITHUB_ACTION_REF - #614
Merged
Conversation
MaddyMicrosoft
marked this pull request as ready for review
August 17, 2026 06:23
…anch The live-tests workflow used a fixed resource group name (GitHubAction_CI_Group) plus a repo-wide concurrency group. Because the test jobs run behind the Automation test approval gate, an unapproved run sits in the 'waiting' state holding the shared concurrency lock, which blocked live-tests on every other PR indefinitely. Give each run its own resource group by suffixing the name with github.run_id, and reference it via the RG_POSITIVE env var everywhere (previously nine jobs used the literal name). With per-run isolation the repo-wide lock is no longer needed to prevent collisions, so the concurrency group is now scoped to the branch (github.ref) and only prevents pile-ups on rapid pushes to the same ref - never across PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MaddyMicrosoft
had a problem deploying
to
Automation test
August 17, 2026 06:46 — with 
GitHub Actions
Failure
GitHub Actions
Failure
MaddyMicrosoft
had a problem deploying
to
Automation test
August 17, 2026 06:46 — with
GitHub Actions
Failure
GitHub Actions
Failure
MaddyMicrosoft
had a problem deploying
to
Automation test
August 17, 2026 06:46 — with
GitHub Actions
Failure
GitHub Actions
Failure
The per-run resource group name was referenced as the bash-style "$RG_POSITIVE" in az group show/create/delete run steps. Those steps use the runner default shell, which is PowerShell on windows-latest, so the name expanded to an empty string there and az failed with "argument --name/-n/--resource-group/-g: expected one argument". Reference the value through the GitHub Actions env expression instead, so it is substituted before the shell runs, making it shell-agnostic across ubuntu, windows, and macos. The azure/powershell inline scripts keep using the PowerShell env form, which is correct there. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MaddyMicrosoft
had a problem deploying
to
Automation test
August 17, 2026 07:04 — with
GitHub Actions
Failure
GitHub Actions
Failure
MaddyMicrosoft
requested review from
Yeming Liu (isra-fel),
Yash (notyashhh),
Teresa Ritorto (teresaritorto) and
xuming-ms
August 18, 2026 01:42
Yeming Liu (isra-fel)
approved these changes
Aug 18, 2026
Member
|
Great idea! Would be nice to have versions even if customer pins a sha or branch, but it's probably not worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reports the action ref the consumer actually pinned in telemetry, instead of a hardcoded version string. Prevents manual changes and drift.
Change
Telemetry: report the actual action ref (
src/common/Utils.ts)The user-agent string hardcoded
@v3, which silently goes stale on a major bump. It now readsGITHUB_ACTION_REF(the ref the consumer pinned, e.g.v3,v3.1.0, a SHA, ormain), falling back tounknown. This never goes stale and distinguishes how consumers actually pin.Live-tests: isolate the resource group per run
The workflow used a fixed RG name plus a repo-wide concurrency group. Because the test jobs sit behind the
Automation testapproval gate, an unapproved run held the shared lock in thewaitingstate and blocked live-tests on every other PR. Each run now provisions its own RG (GitHubAction_CI_Group_${{ github.run_id }}), and the concurrency group is scoped to the branch, so runs never block across PRs.Live-tests: fix RG name expansion on Windows
The RG name was referenced bash-style (
$RG_POSITIVE) inaz groupsteps. Those use the runner default shell, which is PowerShell on windows-latest, so the value expanded to empty andazfailed. It now uses the${{ env.RG_POSITIVE }}expression, which is shell-agnostic.Why
@v3) from an exact version, a SHA, ormain.Notes
@is now the pinned ref rather than always@v3, so downstream parsing that assumed@vNshould bucket the new values. Worth a heads-up to whoever owns the user-agent dashboards.